1Password Mac interferes with Github user management

ndirons

When I'm adding a user to a Github organizational team, Github presents a faux-modal window with a password demand if I haven't authenticated in the last couple of hours.

When I use 1Password to fill my password and hit return, the user who gets added to the team is me, not the user whose addition prompted the password demand. I then have to remove myself and re-add the original user.

---

1Password Version: 6.2.1
Extension Version: 4.5.5
OS Version: 10.11.4
Sync Type: Dropbox

jxpx777

Hey, @ndirons. I'm sorry for the trouble you're having. I don't have access to any teams to see this screen, but I can definitely imagine that if you're filling the Login from 1Password, which contains your username and password, that it would fill a username field on the same page. I will need to get some help gathering the necessary data to hopefully make a test case that we can get from failing to passing. For now, copy and paste will be the best way to avoid 1Password filling that username for you.

--
Jamie Phelps
Code Wrangler @ AgileBits

ref: BRAIN-209

antifuchs

Hi all, I can confirm that this behavior is happening (and it's really frustrating to have 1Password add oneself to a team via auto-submit). I have some details in case you all want to debug this further:

This is the input field that gets clobbered is the "member to add" field, here's the HTML:

<input type="text" name="member" class="form-control subnav-search-input input-contrast auto-search-input js-autocomplete-field" aria-label="Add a person" placeholder="Add a person" autocomplete="off">

The pseudo pop-up form that comes up is this:

<div class="facebox-content sudo" role="dialog" aria-labelledby="facebox-header" aria-describedby="facebox-description">
  <!-- </textarea> --><!-- '"` --><form accept-charset="UTF-8" action="/sessions/sudo" class="js-sudo-form" data-form-nonce="9cdc6c33cf8c30b7c2aa86f69d1f2fd87394b81a" data-remote="true" method="post"><div style="margin:0;padding:0;display:inline"><input name="utf8" type="hidden" value="✓"><input name="authenticity_token" type="hidden" value="TXUcd2cJEJN9W28sB6bq+Eyd8UozD+OrlWru9UxLodUgxosigHz54WSdeA4pi4IDsXk+JvBU+ccVBAHtRxdb6w=="></div>    <div class="auth-form-header">
      <h1>
        Confirm password to continue
        <i class="mini-icon mini-icon-lock"></i>
      </h1>
    </div>
    <div class="flash flash-error sudo-error js-sudo-error"></div>
    <div class="auth-form-body">
        <label for="sudo_password">
          Password <a href="/password_reset">(Forgot password)</a>
        </label>
        <input class="form-control form-control input-block js-sudo-password" id="sudo_password" name="sudo_password" tabindex="2" type="password">

      <button type="submit" class="btn">Confirm password</button>
    </div>
</form></div>

I hope this helps get the autofiller be a bit smarter - would definitely love if we could get github work together better with 1Password (:

AGAlumB

@antifuchs: Thanks so much! Even though 1Password is just trying to do it's job and fill your login credentials (after all, you've got a username there too, which you'd typically want it to fill), but hopefully we'll be able to get 1Password to play more nicely in this case with GitHub. In the mean time, if you edit the item you can disable Autosubmit for it to avoid having to undo the change. Cheers! :)