Chrome extension polluting the dom with data-attributes

Options
lazopm
lazopm
Community Member
in 1Password in the Browser

As a web dev this is a bit annoying and mostly confusing as to why the extension needs to manipulate the DOM to keep track of fields.
Why not just keep references to the nodes?

1Password Version: Not Provided
Extension Version: Not Provided
OS Version: Not Provided
Sync Type: Not Provided

Comments

  • jxpx777
    jxpx777
    1Password Alumni
    Options

    Hi, @lazopm. Thanks for your post and welcome to the forums! You're right that we do use a few DOM attributes to track some values. It's been quite a while since we made this change, so I might have some of the details wrong, but if I recall correctly we had some reliability issues. Our best understanding was that it was an issue with the sandboxing of some of the extensions APIs that caused us our node references to be lost in some situations. We'll revisit this in the future and see if things have improved and if we can get rid of these. I've created an issue to track this so that it doesn't fall off our radar.

    --
    Jamie Phelps
    Code Wrangler @ AgileBits
    Fort Worth, Texas

    ref: OPX-1342

This discussion has been closed.