Extension crashes on search
Searching "r0" in my vault causes the extension to appear to crash, going totally white and then being unusable for a few minutes. Other searches don't seem to exhibit this so perhaps something specific with my vault contents?
Reproducible on Linux and macOS.
1Password Version: n/a
Extension Version: 0.8.4
OS Version: Ubuntu 16.04
Sync Type: 1Password.com
Comments
-
Could be specific to your vault, no crashes for me.
0 -
Hey @arussell,
I'm sorry to hear you're having issues with searching. This isn't something we've heard before, but one of the reasons we are doing this private beta is to weed out any edge case issues as early as possible.
Next time you see this problem, I'd love if you could do the following in Chrome:
1. Right click the 1Password browser extension icon and click Manage Extensions.
2. Enable the Developer Mode check box (at the top).
3. Click the "background page" link next to the 1Password Beta extension.
4. Click the Console tab in the new window that opens and send a screenshot of that page tolinux@1password.com
.I'm going to load some test data and see if I can reproduce this on our end. Thanks for your help!
--
Andrew Beyer (Ann Arbor, MI)
Lifeline @ AgileBits0 -
Weirdly I can't reproduce this any more. I guess we can call this resolved!
0 -
Well right on cue I managed to trigger it again, but nothing telling in the console unfortunately. Different search terms this time, though. Screenshot emailed. :)
0 -
I can reproduce this most of the time on my installation.
It always seems to crash when in a gmail tab, or in a new blank tab.
It makes the extension very hard to use.
0 -
@caseycrop: Thanks for letting us know.
Can you follow the steps here and see if there are any errors (highlighted in red)? Unfortunately, I wasn't able to find any errors in the screenshot @arussell sent us.
If possible I'd like you to check the following as well:
1. Click the 1Password logo (which should display an all white pop-up).
2. Right-click and select inspect.
3. Click the Console tab in the new window that opens and see if any errors are displayed there.Thank you very much for your help!
--
Andrew Beyer (Ann Arbor, MI)
Lifeline @ AgileBits0 -
Yes there are errors, here is the log.
I can reproduce this by:
- switching to gmail tab
- clicking the 1password icon
- clicking in the 1password search bar
- typing one letter, e.g., t
Results: the popup window goes white
popup.js:1 creating new i18n instance popup.js:1 Popup loaded @ 1504089040436. <PRODUCTION=true,SINGLE_PAGE_MODE=false> popup.js:1 Background window: Window popup.js:1 Background window: Window popup.js:1 Rendering react app. Locked=false popup.js:1 @loadPopupRestorePoint {"savedAt":1504089023967,"selectedAccountUUID":null,"selectedVaultUUID":null,"selectedItemUUID":"xqumf5l7g5aehcfj2euwvi6g7m","searchValue":"test","selectedSideBarAction":"Fill"} popup.js:1 ephemeral popup state values ephemeralized popup.js:1 Created <App> element. Elapse time 0ms. popup.js:1 Rendering App: false/true popup.js:1 @MainWindow:constructor Object popup.js:1 @MainWindow.render: searchBy=<>, showEverything=false popup.js:1 Rendering Header popup.js:1 Rendering SettingsMenu; showing false popup.js:1 Rendering SideBar. popup.js:1 @VaultItemList.render: autofocus:true popup.js:1 Item limit 10 was never reached. Returning all sections. popup.js:1 rendering 10 of 5 with focused item null. Array(2) popup.js:1 @VaultItem.itemFocused xqumf5l7g5aehcfj2euwvi6g7m popup.js:1 @VaultItemList.onItemFocused:xqumf5l7g5aehcfj2euwvi6g7m; was null popup.js:1 setState! popup.js:1 @VaultItemList.onFocus popup.js:1 We have no scrolling list! popup.js:1 Main window measurements: popup.js:1 main-mount took 52.3ms popup.js:1 sidebar-mount took 15.8ms popup.js:1 itemlist-mount took 36.3ms popup.js:1 app-total took 62.9ms popup.js:1 app-mount took 62.6ms popup.js:1 @componentDidMount. Locked? No. h popup.js:1 @VaultItemList.render: autofocus:true popup.js:1 Item limit 10 was never reached. Returning all sections. popup.js:1 rendering 10 of 5 with focused item xqumf5l7g5aehcfj2euwvi6g7m. Array(2) popup.js:1 VaultItemList@componentDidUpdate: this.state.itemLimit=10, itemCount=5 popup.js:1 Rendered <App> element. Elapse time 76ms. popup.js:1 @VaultItemList.onBlur <section class="scrolling_list">…</section> <li class="active" tabindex="0" data-item-uuid="xqumf5l7g5aehcfj2euwvi6g7m">…</li> popup.js:1 we lost focus. popup.js:1 @VaultItemList.render: autofocus:true popup.js:1 Item limit 10 was never reached. Returning all sections. popup.js:1 rendering 10 of 5 with focused item xqumf5l7g5aehcfj2euwvi6g7m. Array(2) popup.js:1 VaultItemList@componentDidUpdate: this.state.itemLimit=10, itemCount=5 popup.js:1 @Header.onKeypress! KeyboardEvent true popup.js:1 @MainWindow.render: searchBy=<t>, showEverything=false popup.js:1 Rendering Header popup.js:1 Rendering SettingsMenu; showing false popup.js:1 SideBar@shouldComponentUpdate? YES popup.js:1 Rendering SideBar. popup.js:1 @VaultItemList.render: autofocus:true popup.js:1 Item limit 10 was never reached. Returning all sections. popup.js:1 rendering 10 of 5 with focused item xqumf5l7g5aehcfj2euwvi6g7m. Array(2) popup.js:1 VaultItemList@componentDidUpdate: this.state.itemLimit=10, itemCount=5 popup.js:1 @MainWindow.render: searchBy=<t>, showEverything=false popup.js:1 Rendering Header popup.js:1 Rendering SettingsMenu; showing false popup.js:1 SideBar@shouldComponentUpdate? YES popup.js:1 Rendering SideBar. popup.js:1 @VaultItemList.render: autofocus:true popup.js:1 Item limit 10 was never reached. Returning all sections. popup.js:1 rendering 10 of 5 with focused item xqumf5l7g5aehcfj2euwvi6g7m. Array(2) popup.js:1 VaultItemList@componentDidUpdate: this.state.itemLimit=10, itemCount=5 popup.js:1 Background window: Window popup.js:1 Background window: Window popup.js:1 @Header.onKeypress! KeyboardEvent true popup.js:1 @MainWindow.render: searchBy=<te>, showEverything=false popup.js:1 Rendering Header popup.js:1 Rendering SettingsMenu; showing false popup.js:1 SideBar@shouldComponentUpdate? YES popup.js:1 Rendering SideBar. popup.js:1 @VaultItemList.render: autofocus:true popup.js:1 Item limit 10 was never reached. Returning all sections. popup.js:1 rendering 10 of 5 with focused item xqumf5l7g5aehcfj2euwvi6g7m. Array(2) popup.js:1 VaultItemList@componentDidUpdate: this.state.itemLimit=10, itemCount=5 popup.js:1 @MainWindow.render: searchBy=<te>, showEverything=false popup.js:1 Rendering Header popup.js:1 Rendering SettingsMenu; showing false popup.js:1 SideBar@shouldComponentUpdate? YES popup.js:1 Rendering SideBar. popup.js:1 @VaultItemList.render: autofocus:true popup.js:1 Item limit 10 was never reached. Returning all sections. popup.js:1 rendering 10 of 5 with focused item xqumf5l7g5aehcfj2euwvi6g7m. Array(2) popup.js:1 VaultItemList@componentDidUpdate: this.state.itemLimit=10, itemCount=5 popup.js:1 Background window: Window popup.js:1 Background window: Window popup.js:1 @Header.onKeypress! KeyboardEvent true popup.js:1 @MainWindow.render: searchBy=<tes>, showEverything=false popup.js:1 Rendering Header popup.js:1 Rendering SettingsMenu; showing false popup.js:1 SideBar@shouldComponentUpdate? YES popup.js:1 Rendering SideBar. popup.js:1 @VaultItemList.render: autofocus:true popup.js:1 Item limit 10 was never reached. Returning all sections. popup.js:1 rendering 10 of 5 with focused item xqumf5l7g5aehcfj2euwvi6g7m. Array(2) popup.js:1 VaultItemList@componentDidUpdate: this.state.itemLimit=10, itemCount=5 popup.js:1 @MainWindow.render: searchBy=<tes>, showEverything=false popup.js:1 Rendering Header popup.js:1 Rendering SettingsMenu; showing false popup.js:1 SideBar@shouldComponentUpdate? YES popup.js:1 Rendering SideBar. popup.js:1 @VaultItemList.render: autofocus:true popup.js:1 Item limit 10 was never reached. Returning all sections. popup.js:1 rendering 10 of 5 with focused item xqumf5l7g5aehcfj2euwvi6g7m. Array(2) popup.js:1 VaultItemList@componentDidUpdate: this.state.itemLimit=10, itemCount=5 popup.js:1 Background window: Window popup.js:1 Background window: Window popup.js:1 @MainWindow.render: searchBy=<tes>, showEverything=false popup.js:1 Rendering Header popup.js:1 Rendering SettingsMenu; showing false popup.js:1 SideBar@shouldComponentUpdate? YES popup.js:1 Rendering SideBar. popup.js:1 @VaultItemList.render: autofocus:true popup.js:1 rendering 10 of 10 with focused item xqumf5l7g5aehcfj2euwvi6g7m. Array(3) popup.js:1 React caught an error thrown by one of your components. TypeError: Cannot read property 'indexOf' of undefined at Object.n [as findFirstOneTimePasswordField] (chrome-extension://khgocmkkpikpnmmkgmdnfckapcdkgfaf/popup/popup.js:1:626744) at d.render (chrome-extension://khgocmkkpikpnmmkgmdnfckapcdkgfaf/popup/popup.js:1:1038938) at d (chrome-extension://khgocmkkpikpnmmkgmdnfckapcdkgfaf/popup/lib/react-dom.js:6:9654) at c (chrome-extension://khgocmkkpikpnmmkgmdnfckapcdkgfaf/popup/lib/react-dom.js:6:9529) at k (chrome-extension://khgocmkkpikpnmmkgmdnfckapcdkgfaf/popup/lib/react-dom.js:6:11858) at u (chrome-extension://khgocmkkpikpnmmkgmdnfckapcdkgfaf/popup/lib/react-dom.js:6:24810) at p (chrome-extension://khgocmkkpikpnmmkgmdnfckapcdkgfaf/popup/lib/react-dom.js:6:25283) at h (chrome-extension://khgocmkkpikpnmmkgmdnfckapcdkgfaf/popup/lib/react-dom.js:6:25830) at E (chrome-extension://khgocmkkpikpnmmkgmdnfckapcdkgfaf/popup/lib/react-dom.js:6:28062) at Object.enqueueSetState (chrome-extension://khgocmkkpikpnmmkgmdnfckapcdkgfaf/popup/lib/react-dom.js:6:7705) e.(anonymous function) @ popup.js:1 popup.js:1 Uncaught (in promise) TypeError: Cannot read property 'indexOf' of undefined at Object.n [as findFirstOneTimePasswordField] (popup.js:1) at d.render (popup.js:1) at d (react-dom.js:6) at c (react-dom.js:6) at k (react-dom.js:6) at u (react-dom.js:6) at p (react-dom.js:6) at h (react-dom.js:6) at E (react-dom.js:6) at Object.enqueueSetState (react-dom.js:6) importing_from_installer.png Failed to load resource: the server responded with a status of 404 () cropster.agilecrm.com.png Failed to load resource: the server responded with a status of 404 ()
0 -
@caseycrop: Thank you very much for sending this over, I believe we might be able to grab some valuable information out of this.
We will work on getting this resolved for a future release of 1Password.
--
Andrew Beyer (Ann Arbor, MI)
Lifeline @ AgileBits0