1Password X Beta and Google's Admin pages don't seem to be getting along any more

lrosenman

When going to https://admin.google.com, 1P X Beta is no longer offering fill-in's, nor is autofill from the extension bar.

---

1Password Version: 1Password 7 Version 7.4.BETA-0 (70400000) 1Passwor
Extension Version: 1.17.2
OS Version: macOS 10.15 (catalina)
Sync Type: 1P Accounts

lrosenman

example

cecelia

Hey @lrosenman! Thanks for reaching out. That's super weird, especially since this beta release was specifically supposed to improve the inline Suggestions behavior on Google. I'm unable to reproduce this but am eager to figure out what's going on. If you open the 1Password X popup in the browser's toolbar to "Suggestions" view while at https://admin.google.com/, do you see your Google logins? Can you also check if your Google Logins have the word Google or Gmail in their titles as well as a proper Google URL? Cheers!

lrosenman

yep

lrosenman

chrome version, and macOS Catalina

kaitlyn

Thanks for sharing those additional details, @lrosenman. I haven't been able to reproduce this myself. Do you notice the same thing when you sign into your Google account at accounts.google.com, or does this only happen on admin.google.com?

lrosenman

Hard to tell, as that doesn't ask for password nearly as often as https://admin.google.com does, and I don't really want to sign out from my google accounts. (I stay signed into at least 2 all the time, work, and my personal one).

lrosenman

I did get a chance to try it, and same issue with accounts.google.com

cecelia

Hey @lrosenman. Thanks for taking the time to check on that for us. I've launched admin/accounts.google.com in several different browsers (including Chrome beta) using the 1Password X beta and am still unable to reproduce this. I'm curious if Google's the only place this is happening or if it's happening on other sites for you as well.

If it's just Google, I'd like to collect some info and then try to shake up the inline menu a little to see if it fixes things (if you don't mind).

1. Can you go to a Google login form (anywhere this is happening) and activate the inline menu (by clicking in a field or clicking on the 1Password icon in the field), then when no Suggestions appear, can you check the console logs for any errors? Here are the instructions for collecting console logs

Feel free to send them to us here or in an email to support+x@1password.com with a link to this discussion.

2. Once you've checked the logs, can you click "Suggestions" in the inline menu, then click "Logins." Are your Google Login items showing? What happens if you now go back to "Suggestions?"

lrosenman

Here's the log, when I click suggestions, nothing happens.

[I] ➜ cat Downloads/accounts.google.com-1572032176783.log
14:34:45.529 VM21 ServiceLogin:1 A cookie associated with a resource at http://www.google.com/ was set with SameSite=None but without Secure. A future release of Chrome will only deliver cookies marked SameSite=None if they are also marked Secure. You can review cookies in developer tools under Application>Storage>Cookies and see more details at https://www.chromestatus.com/feature/5633521622188032.
14:34:45.962 content.bundle.js:5 runtime.onMessageExternal is not supported
t.default @ content.bundle.js:5
14:34:45.986 content.bundle.js:5 runtime.onConnectExternal is not supported
t.default @ content.bundle.js:5
14:34:46.490 /ServiceLogin/webreauth?continue=https%3A%2F%2Fadmin.google.com%2Fwhereto.com%2FDashboard&service=CPanel&skipvpage=true&passive=3600&authuser=1&flowName=GlifWebSignIn&flowEntry=ServiceLogin:1 A cookie associated with a cross-site resource at http://youtube.com/ was set without the SameSite attribute. A future release of Chrome will only deliver cookies with cross-site requests if they are set with SameSite=None and Secure. You can review cookies in developer tools under Application>Storage>Cookies and see more details at https://www.chromestatus.com/feature/5088147346030592 and https://www.chromestatus.com/feature/5633521622188032.
14:34:46.490 /ServiceLogin/webreauth?continue=https%3A%2F%2Fadmin.google.com%2Fwhereto.com%2FDashboard&service=CPanel&skipvpage=true&passive=3600&authuser=1&flowName=GlifWebSignIn&flowEntry=ServiceLogin:1 A cookie associated with a cross-site resource at https://youtube.com/ was set without the SameSite attribute. A future release of Chrome will only deliver cookies with cross-site requests if they are set with SameSite=None and Secure. You can review cookies in developer tools under Application>Storage>Cookies and see more details at https://www.chromestatus.com/feature/5088147346030592 and https://www.chromestatus.com/feature/5633521622188032.
14:34:46.695 /ServiceLogin/webreauth?continue=https%3A%2F%2Fadmin.google.com%2Fwhereto.com%2FDashboard&service=CPanel&skipvpage=true&passive=3600&authuser=1&flowName=GlifWebSignIn&flowEntry=ServiceLogin:1 A cookie associated with a cross-site resource at http://accounts.youtube.com/ was set without the SameSite attribute. A future release of Chrome will only deliver cookies with cross-site requests if they are set with SameSite=None and Secure. You can review cookies in developer tools under Application>Storage>Cookies and see more details at https://www.chromestatus.com/feature/5088147346030592 and https://www.chromestatus.com/feature/5633521622188032.
14:34:48.905 pwd:1 A cookie associated with a resource at http://gstatic.com/ was set with SameSite=None but without Secure. A future release of Chrome will only deliver cookies marked SameSite=None if they are also marked Secure. You can review cookies in developer tools under Application>Storage>Cookies and see more details at https://www.chromestatus.com/feature/5633521622188032.
14:34:58.964 chrome-extension://khgocmkkpikpnmmkgmdnfckapcdkgfaf/inline/menu/menu.js:6694 Uncaught (in promise) TypeError: Cannot read property 'toLowerCase' of undefined
at chrome-extension://khgocmkkpikpnmmkgmdnfckapcdkgfaf/inline/menu/menu.js:6694
at Array.sort ()
at Object.$$self.$$.update (chrome-extension://khgocmkkpikpnmmkgmdnfckapcdkgfaf/inline/menu/menu.js:8340)
at update (chrome-extension://khgocmkkpikpnmmkgmdnfckapcdkgfaf/inline/menu/menu.js:270)
at flush (chrome-extension://khgocmkkpikpnmmkgmdnfckapcdkgfaf/inline/menu/menu.js:246)
14:35:07.760 menu.js:6694 Uncaught (in promise) TypeError: Cannot read property 'toLowerCase' of undefined
at menu.js:6694
at Array.sort ()
at Object.$$self.$$.update (menu.js:8340)
at update (menu.js:270)
at flush (menu.js:246)
(anonymous) @ menu.js:6694
$$self.$$.update @ menu.js:8340
update @ menu.js:270
flush @ menu.js:246
Promise.then (async)
schedule_update @ menu.js:232
make_dirty @ menu.js:547
(anonymous) @ menu.js:581
getItems @ menu.js:8182
async function (async)
getItems @ menu.js:8182
$$self.$$.update @ menu.js:8337
init @ menu.js:586
Frame @ menu.js:8370
create_if_block$9 @ menu.js:8387
p @ menu.js:8473
update @ menu.js:272
flush @ menu.js:246
Promise.then (async)
schedule_update @ menu.js:232
make_dirty @ menu.js:547
(anonymous) @ menu.js:581
(anonymous) @ menu.js:8524
registeredHandler @ menu.js:653

~
[I] ➜

kaitlyn

Thank you, @lrosenman. I've filed this with our developers in hopes they'll have a solution for us. Hang in there, and I'll update you as soon as I hear back.

ref: dev/core/core#326

kaitlyn

Quick update for you, @lrosenman! Thanks to the logs you sent in, we were able to find the root cause of the issue. The fix is being tested internally now, but we should be able to release it to you in an upcoming beta version. I'll keep you posted. :)

lrosenman

I'm seeing weird (very similar to this) with: https://owner.ford.com

Do you need logs from that or do we think this upcoming fix might be it?

kaitlyn

@lrosenman – Part of me is thinking this may be a completely separate issue. Could you let me know the website URL you have stored inside your Ford item? The reason I ask if because you're redirected to a different URL when clicking the sign in button, so you'll have to make sure that's one of the URLs inside the item for 1Password to fill there. Let me know what you find!

lrosenman

owner.ford.com <- the one I use

lrosenman

The URL redirect goes to:
https://fcis.ice.ibmcloud.com/authsvc/mtfim/sps/authsvc?PolicyId=urn:ibm:security:authentication:asf:basicldapuser&amp;Target=https://fcis.ice.ibmcloud.com/oidc/endpoint/default/authorize?qs=e29iZjJ9TXlOR3VIb2xFOGtmZjlkeUM5NWd6Sk5hT3RCTTE1cWlyb0lwNnM2U1FmQzJOdEt2S0Nka1AzNlZjQjV1NFZNMUFKeHRpY2ZYNXY3SC8wbVQ5RFVSd1dVREhZbXJVUHh6SHAyUCtiRjdoK0pJT3dsbHJ6cGVPS3ZYTHdYbjNJR0dJUWlRMXlFWVVPbGh1U1V2Z2x6YzQvRHVkajJIRFNRdXdlN0NnZGdPM3BUOTI2b29VVCtwU2lvd0JjWDlwNkVSNWRkNjRFNG42ckNLTUJYS2xCdmc5WlZ4Y2xhMTV6Ri9WNnVsd3A4RW0zTkhCYnFtaVdxNlo2YXkvcUZ4K3ZKMWw2VmFmUEswNlQ5aDVIQTZlK3ZlL3ppYWZ0MHhTdi9mOWlQd1lCSzhENUpiY2hQRFNyUFdaN0w5NlRSR2pNTE5WNVNITkhUamZ6T0tIUFJKbVlyUDl2TUUranRqR3dTSzZjbU42TVRRQXdrdUlpTlNXeEVXNWt1ZFFYSWNTWHIv&amp;identity_source_id=75d08ad1-510f-468a-b69b-5ebc34f773e3#appID=5a5d9080-5134-11e7-a639-000d3a196736&amp;forwardText=Owner&amp;backwardText=Owner&amp;footerID=owner_ford-en-2019-v1&amp;originURL=https://owner.ford.com/index.html&amp;enableRegConfEmail=true&amp;brand=ford&amp;lang=en

I added this (https://fcis.ice.ibmcloud.com) to the 1Password card and it works.

bundtkate

That actually makes perfect sense, @lrosenman, though I can understand how it's a confusing implementation. When 1Password is matching your Login item to the page you're on, it's reading that fcis.ice.imbcloud.com URL and, until you added that URL, that obviously didn't match what you had entered in your Login item. But, from your point of view, you're visiting owner.ford.com and reasonable added that URL to your Login item. What Ford looks to have done here is redirected you to some variety of third-party service that handles sign-in on this site without putting it on their domain, which is confusing to 1Password and, in my opinion, could be equally confusing to customers paying attention to their address bars. A lot of companies have third-party services handle these things, but in my experience most at least use a domain that will be familiar to their customers and it looks like Ford chose not to do this and instead of have the familiar domain redirect. It works, I guess, but I feel like my preference would be to ensure it's my domain that's exposed to my customers.

Regardless, I'm glad you figured it out and this can serve as a nice lesson for all of us. Redirects are pretty darned common and while most will go to the same domain meaning 1Password doesn't care, stuff like this totally can happen and taking a quick peek in your address bar to make sure the domain matches what you have saved is always a great first step when having this sort of trouble. :+1:

lrosenman

I'm well aware, and this USED to work. Apparently FORD changed to use IBMCLOUD for the auth. I'm a Site Reliability Engineer by trade,

Thanks for the quick diagnosis. Is there anyway y'all can have an "alias" list for stuff like this?

AGAlumB

@lrosenman: Yep that would do it. Very confusing when that happens. 1Password will never offer to fill on a page that doesn't match what's saved in the Login, as otherwise it's easy to fall prey to phishing scams. But in cases where you do want to be able to fill a Login on multiple websites, editing it to add multiple URLs will work. Cheers! :)

lrosenman

another along the same lines, but different. Progressive Insurance website, 1PX fills in the password, but NOT the username.

Ideas?

kaitlyn

@lrosenman – Would you mind saving a Login item using the following steps?

1. Copy/paste your username and password into the proper fields.
2. Click the 1Password icon inside the password field.
3. Click Save in 1Password.
4. Select the vault you'd like and click Save. You may want to give the item a new name so you can distinguish it from your existing item.
5. Refresh the page and attempt to fill the item you just created (either with the inline menu in the password field or from the pop-up).

Let me know if the new item fills any better for you!

lrosenman

The new item DOES fill in, BUT no 1P icon on the username field, and it shows wierd:

kaitlyn

@lrosenman – Thanks for the additional info! I brought the issue up to our developers. We're prioritizing a couple of important projects at the moment, but we'll work towards a fix as soon as we can.

ref: dev/core/core#461

lrosenman

Yay! 1PX 1.17.3 fixes my original whine about Google's admin pages :)

kaitlyn

@lrosenman – That's great to hear! I've been meaning to reach out to you about it to make sure 1.17.3 resolved things for you. I'm so glad it did. :chuffed:

lrosenman

And 1.17.4 fixes Progressive! Thanks!

cecelia

Yay! So happy to hear that, @lrosenman. You're very welcome, and thank YOU for keeping us updated. ❤️