Feature Request - Display (wifi) qr code

Riku55

Hey there, using 1password for over a year now and it's great!
Now I was just about to set up my wifi on a new android device and since it's getting more and more common to just use a qr code instead of typing the password in, I was thinking that 1password for sure would have an option to save qr codes in objects and display them directly inside the app. I was a bit baffled to find out it doesn't. Sure, I can attach the image, but to see it, I would need to manually download and open it with another app which I don't think is very convenient on lots of devices. If you just had an option to add a "QR code" field just as you add text, url, e-mail, address etc that would have a reveal/hide button, that would be very convenient and a great addition to a great service that 1password is :)

---

1Password Version: Not Provided
Extension Version: Not Provided
OS Version: Not Provided
Browser: Not Provided

ag_tommy

Thanks @Riku55 for the suggestion. I'll get this before the products team for consideration.

ref: PB-38036415

fernandog

I vote up for this feature, but I would like to suggest a workaround in the mobile app. There is a "preview" button for attached image (at least in the Document type), so you don't need to download the image (at least not in the user Download folder). Not the smart solution if you change your password every N weeks/months

ag_tommy

@fernandog

I'm all for the preview option. Thanks for sharing.

BionicBison05

Not sure if this is still under consideration, but with a WiFi item containing all the necessary information, maybe 1Password could go one step further and be able to generate a valid WiFi QR code?

ag_tommy

I'll let the team know this interests you. 🙂

ref: PB-39224134

ag_andrew

Hey @Riku55 @fernandog @BionicBison05 👋

I’m so excited to be able to tell you that this feature is now available in the beta releases of 1Password 8!

We can’t wait to hear what you think. Keep the great ideas and feedback coming 💙

fernandog

@ag_andrew
Great! Working, but not for all. This one for example, there is no qrcode:

ag_andrew

Hey @fernandog,

Are you using the Beta build of 1Password? That configuration of a Wireless Router item should produce a QR code in build 8.10.36-1.BETA

fernandog

yes. Others items does show the qrcode. This one and another, doesn't

ag_andrew

@fernandog Strange. It should be using the item title as the network name (in the QR code) when the network name field is not filled out, but just in case can you try setting the network name field to see if that helps?

fernandog

didn't work. Mind that my field name is translated, so I used the translated name and the one that you provided. both didn't work.

Creating a new router item, works.
Maybe there is some property on the item (not shown in the UI) that prevents from showing. Again, some items shows the QR code, some other don't. I couldn't understand why.

fernandog

I think I found the issue:

Using the CLI, I called a "op item get" and I noticed that the item that doesn't work, doesn't have a ID item called "wireless_password" in the fields section.

The router item that works has this and other IDs in the fields section:

{
  "id": "wireless_password",
  "type": "CONCEALED",
  "label": "Senha da rede sem fio",
  "value": "******",
  "reference": "op://Private/*****/Senha da rede sem fio"
},

Full json of the item that doesn't work:

{
  "id": "f3rhvx3*****",
  "title": "******",
  "tags": ["Roteador"],
  "version": 9,
  "vault": {
    "id": "eng4sm*****",
    "name": "Private"
  },
  "category": "WIRELESS_ROUTER",
  "last_edited_by": "*****",
  "created_at": "2024-01-14T02:00:07Z",
  "updated_at": "2024-06-17T19:22:58Z",
  "sections": [
    {
      "id": "add more"
    }
  ],
  "fields": [
    {
      "id": "notesPlain",
      "type": "STRING",
      "purpose": "NOTES",
      "label": "notesPlain",
      "reference": "op://Private/*****/notesPlain"
    },
    {
      "id": "jzwoog4a******",
      "section": {
        "id": "add more"
      },
      "type": "CONCEALED",
      "label": "Senha da rede sem fio",
      "value": "*****",
      "reference": "op://Private/******/add more/Senha da rede sem fio"
    }
  ]
}

fernandog

I think that happens, because when you create a new router item, you have the possibility of deleting the fields:

ag_andrew

@fernandog My hunch is that something has changed in the item JSON that has broken an expectation baked into the QR code.

If you have time to look into it:

step	screenshot
Enable debug mode in Settings > Advanced
Copy the JSON of one of your Wireless Router Items to the clipboard
Paste the JSON in a text file and look for your wireless network password. I want to know if the n value is "wireless_password" the way mine is

The QR code is looking for the wireless_password identifier to find that field. I'm interested to know if your older items are using a different identifier for that field.

fernandog

@ag_andrew
Check my previous message with the CLI output.

ag_andrew

@fernandog You were way ahead of me! 🎉

In order for us to correctly display the QR code we want to be very certain we are using the correct password. So we look for a specific field identifier.

This keeps us from incorrectly revealing (for example) your router's admin password as part of the QR code.

fernandog

@ag_andrew using your UI debug option:

noticed the "t" the translated value of the "wireless_password".

    "fields": [
      {
        "t": "Senha da rede sem fio",
        "n": "jzwoog****",
        "k": "concealed",
        "v": "****",
        "inputTraits": {
          "autocorrection": "no",
          "autocapitalization": "none"
        }

ag_andrew

@fernandog Cool, yeah the t is the localized label of the field. But it's the identifier (the n value) that we use to find the password for the purpose of the QR code.

fernandog

@ag_andrew
Ok, thanks. I created the items, and it's all good now. Thanks for your time. I guess this didn't work because the password was in a standard "password" field and not a "wireless_password" field.

Hope this help others to understand why the QR code doesn't show

ag_andrew

@fernandog Thank you for helping get to the bottom of it. I'll make sure this gets included in the support material for this feature.

Glad it's up and running for you. Hope you find it useful!