Arrow keys don't work within the inline menu

System
System
in 1Password in the Browser
This discussion was created from comments split from: 1Password Helper auto-closing, v2.

Comments

  • craig_francis
    craig_francis
    Community Member

    Thanks Dave, and glad to hear you're looking at application/xhtml+xml again (it worked in 1Password for years, then broke a few months ago, got fixed, and then broke again).

    As to the second issue (using the down arrow to select a login), I really don't know how to replicate it, as it seems to be random; as in, it will work fine for a few logins, then it won't, but a page refresh will sometimes fix, or I just go back to using my mouse... that said, I am quite often logging into websites that I've created, and they use application/xhtml+xml, which I know is unusual (but it's good way to ensure a certain type of XSS vulnerabilities cannot exist; e.g. it ensures all HTML attributes are quoted)... as to browser, I've only noticed it in Google Chrome, but that's because I'm not doing any multi-browser testing work at the moment... as soon as I find a pattern, or get to create a test case, I'll let you know.

  • Dave_1P
    Dave_1P

    @craig_francis

    Thank you for the reply. The next time that you encounter the issue could you send in a console log so that the team and I can investigate this further:

    Attach the file to an email message addressed to support+forum@1password.com.

    With your email please include:

    You should receive an automated reply from our BitBot assistant with a Support ID number. Please post that number here. Thanks very much!

    -Dave

  • craig_francis
    craig_francis
    Community Member

    Yep, will do, thanks Dave.

  • Dave_1P
    Dave_1P

    Thank you! The team will keep an eye out for your email. 🙂

    -Dave

  • craig_francis
    craig_francis
    Community Member

    Small development, but I still can't isolate...

    It seems that when it happens, it relates to the browser tab; as in, refreshing the page does not fix, nor does going to a new website, but opening a new tab does fix things.

    There is nothing unusual in the extension service worker console log, just the usual:

    📥 Received message from native core <3554744055>
    📤 Sending message to native core <837047558>
    📥 Received message from native core <837047558>

    And the developer tools console for the website just shows the "Retrieving "b5x-stateful-inline-icon" flag errored: timed out - falling back" error which seems to be a feature of 1Password 2.22.1.

    What happens... when I press the [down-arrow] key once, the drop down menu appears without selecting any logins from the list (normal, although I don't know why it didn't select the first entry by default)... then the second [down-arrow] press, it will either do nothing, or the drop down disappears (that seems to be dependent on the websites Content-Security-Policy)... if pressing [down-arrow] once, I can press [tab] and that brings the first item into focus... if using the mouse, everything is fine.

    Looking at your iframe, in the shadow-root, I can see a tabindex="0" on the

    <

    ul>, I assume that gets the focus... then you have an

    for each login, and only

    <

    div>'s inside of them... I assume it's menu.js that handles the focus, but it's too big and minified for a quick check on what it's doing.

  • Dave_1P
    Dave_1P

    @craig_francis

    Thanks for the reply. The "b5x-stateful-inline-icon" message noise in the console is something that our development team is working on fixing. The team is testing a fix in the nightly version of 1Password in the browser and hope to release the fix to the beta and stable versions as soon as possible.

    What happens... when I press the [down-arrow] key once, the drop down menu appears without selecting any logins from the list (normal, although I don't know why it didn't select the first entry by default)... then the second [down-arrow] press, it will either do nothing, or the drop down disappears (that seems to be dependent on the websites Content-Security-Policy)... if pressing [down-arrow] once, I can press [tab] and that brings the first item into focus... if using the mouse, everything is fine.

    This sounds like it might be related to an issue that our team is tracking. If you're able to send in the information that I mentioned in my previous post then our specialists will be able to dig deeper. 🙂

    -Dave

    ref: dev/core/core#25848
    ref: dev/core/core#28962

  • craig_francis
    craig_francis
    Community Member

    Hi Dave, the console log for the extension service worker does not contain anything useful... when it happens next time I'll hopefully have a bit more time to debug it. I suspect it's something to do with the focus, and it's interaction with the iframe and shadow-root.

  • Dave_1P
    Dave_1P

    Thank you, the support team can help investigate this further via email. If you do send them an email then let me know the Support ID and I'll make sure that your email gets to the correct team right away. 🙂

    -Dave

This discussion has been closed.