Crash on iPad when calling findLoginForURLString - invalid presentation of UIActivityViewController

blork

Calling findLoginForURLString::: causes the following crash on iPad:

*** Terminating app due to uncaught exception 'NSGenericException', reason: 'UIPopoverPresentationController (<_UIAlertControllerActionSheetRegularPresentationController: 0x14457a8c0>) should have a non-nil sourceView or barButtonItem set before the presentation occurs.'

UIActivityViewController's UIPopoverPresentationController needs to have one of the following set to be properly presented:

• sourceView and sourceRect

• barButtonItem

Unless I'm missing something there's no way for a caller to set these properties. I suggest 2 new methods to replace findLoginForURLString::: that take the missing variables, or, alternatively, just return the UIActivityViewController and let the caller deal with presentation.

MikeT

Hi @blork,

Thanks for reporting this. This is the same issue as the open issue we have in our Github repo here: https://github.com/AgileBits/onepassword-app-extension/issues/45

Please follow up or watch the issue there and file issues in our repo instead of this forum.