Issue saving icon for Software License

Options
ScreamingPict
ScreamingPict
Community Member

I have a wee issue- usually when I save software licenses I just drag the app onto the 1Password window and fill-in the few remaining details.

However this time I am trying to save the license for some software that I have on another Mac.

So I manually created a new "Software License" item and populated the details. At the same time I dragged an icon out of an email and dropped it onto the Icon area next to the title.

The icon appeared. However as soon as I click 'save' the icon reverts to the default 1Password Software License item icon (the ruler, pencil and brush icon).

I have tried to add the icon by first saving it to disk and dragging it onto the item whilst editing. I have tried with different icons. In every case it appears to have set correctly until you click 'save', at which point the icon reverts.

Any idea what might be going on?
Thanks in advance.

Comments

  • Drew_AG
    Drew_AG
    1Password Alumni
    Options

    Hi @ScreamingPict,

    That's definitely an odd issue! I've been trying this several different ways, but I haven't been able to reproduce this problem. Whenever I create a new Software License item and drag an image to the icon, it saves that correctly for me when I click the Save button (I also tried the ⌘S keyboard shortcut, which also worked). Can you confirm which version of 1Password you're using? I tested this in version 5.3. Also, are you using the AgileBits Store version or the Mac App Store version?

    I wonder if you could also try a quick test for me:

    • Open 1Password and go to File > New Item > Software License
    • Find a different image on your Mac (jpg, png, etc) and drag it to the icon of the new Software License item
    • Assuming the icon is changed, click the Save button

    Does the same problem happen, or does that work? Let us know how it goes, thanks!

  • ScreamingPict
    ScreamingPict
    Community Member
    Options

    Drew,

    Sorry I should have given you this info up-front: I'm using 5.3 (530029) from the Mac App Store.

    Creating another new item, dragging a new image onto the icon area and clicking SAVE does not seem to work... sometimes

    What I've found is;

    • I can't get a PNG image to work
    • I can get some JPEGs to work
    • This is happening in both of the vaults I have (one in Dropbox and one in iCloud)

    For instance

    Curiouser and curiouser...

    ...and when I drag a JPEG into the icon area that will not save, it displays OK (until you click save) but the console says...

    16/04/2015 19:14:19.387 1Password[2423]: 530029 [DATABASE:0x6100000752c0:] E setCustomIconImage:fileData: | Failed to set custom icon as PNG, data is too large: 62937 bytes. Trying JPEG: 19986 bytes.
    16/04/2015 19:14:19.387 1Password[2423]: 530029 [DATABASE:0x6100000752c0:] E setCustomIconImage:fileData: | Failed to set custom icon, JPEG data is too large: 19986 bytes. Will try again with less quality
    16/04/2015 19:14:19.388 1Password[2423]: 530029 [DATABASE:0x6100000752c0:] E setCustomIconImage:fileData: | Failed to set custom icon, JPEG data is too large: 18645 bytes. Giving up

  • Drew_AG
    Drew_AG
    1Password Alumni
    edited April 2015
    Options

    Hi @ScreamingPict,

    Thank you for all the details! I've been trying to reproduce the problem in both the Mac App Store and AgileBits Store versions of 1Password 5.3, but so far it's working correctly for me using my own images and the ones from your links - thanks for those, by the way!

    So I did a bit more digging, and it turns out another customer reported this issue a few months ago, in this discussion. The result was that we opened a bug report, but it's been very difficult for our developers to track down the exact cause because no one here has been able to reproduce the problem on our own systems. What I know about the way it works (or should work) is that when you drag an image into the icon field, 1Password tries to shrink the image down to meet certain conditions. It tries that a few times, getting more aggressive each time, but after that it will concede defeat if it doesn't succeed for some reason. The problem is that we don't know why it fails on your Mac but works correctly on ours with the same images. 1Password simply invokes a system call to shrink the image so it should work the same way on different systems.

    ref: OPM-2575

  • Drew_AG
    Drew_AG
    1Password Alumni
    Options

    @ScreamingPict, I actually just got more information about this from our developers. Apparently they know what the problem is now, so you don't need to send us a diagnostics report (I'll edit my previous message to avoid confusion).

    Hopefully our developers will be able to improve this at some point, but for now there's a workaround: Before trying to add an image to the item, you can try manually saving a copy of the image which is smaller and fits within 16kb. You should be able to add the smaller copy of the image as a custom icon with no problem.

    I'm sorry for the inconvenience! Hopefully the workaround is helpful. If you have any questions about that, please let us know, thanks!

  • ScreamingPict
    ScreamingPict
    Community Member
    Options

    Drew- Thanks! That works. Can't believe I didn't think to try <16KB given that the one working file was the smallest...
    Glad I wasn't just smoking crack and there was a genuine issue here. Was starting to wonder...

  • littlebobbytables
    littlebobbytables
    1Password Alumni
    Options

    Hi @ScreamingPict,

    It's even a little odder. We've seen inconsistent results in the attempts from the system call to shrink an image. When we first came across this issue both my machine and Rick's, one of our developers produced the exact same results in shrinking the image. The very same image for one of our users though, and remember, this is a system call using an OS X library that is present on everybody's machine, failed for them. We never managed to determine why this was the case but if it happens then manually shrinking an image to bypass this is a solution. Hopefully manually shrinking an image isn't required too often but at least you know why this is happening.

  • ScreamingPict
    ScreamingPict
    Community Member
    Options

    Heh- Littlebobbytables. Legendary username.

    OK this might be one of those odd things that crops up now and again- I'm totally happy to manually resize stuff for now.

    The only diagnostic hint that I might be able to give you is that I have, in the past, had some odd behaviour due to sandboxing on my Mac that seemed to have worked on other peoples' Macs. When I try the same steps using the same images on my other Mac everything works just fine.

  • Drew_AG
    Drew_AG
    1Password Alumni
    Options

    Thanks for the additional info @ScreamingPict, that's definitely strange and seems to indicate something specific on your Mac that is causing a problem when 1Password tries to shrink those images. Hopefully we can make improvements on our end that will help with that, but in the meantime I'm glad to hear the workaround is helpful!

    We're always happy to help, so please let us know if you need anything else. :)

This discussion has been closed.