Consider replacing 1Browser with SafariViewController [under consideration]

yosph
yosph
Community Member
edited January 2016 in iOS

Any way to replace 1Password's custom browser with a SafariViewController? Or have an "Enable content blockers" option to toggle between the custom browser and Safari View Controller? This would allow adblockers to work in 1Password.


1Password Version: Not Provided
Extension Version: Not Provided
OS Version: Not Provided
Sync Type: Not Provided

Comments

  • Rad
    Rad
    1Password Alumni

    Hi @yosph,

    Thanks so much for taking the time to write in :+1:

    1Password's custom browser, 1Browser, is currently asked on the WKWebView API. There have been numerous discussions suggesting replacing 1Browser with a SFSafariViewController, so we filed an internal bug (OPI-2626) and I'll add your vote to it.

    What you are saying about third party content blockers is totally true, they will simply work in the said 1Password SFSafariViewController. However, if 1Browser is no longer available, we would not be able to perform Go and Fill (Tapping on an 1Password Login's URL will open the website and fill-in the username and password) in SFSafariViewControllers like we currently do in 1Browser's WKWebView.

    If you have any other questions, please do not hesitate to ask :wink:

    Cheers!

  • yosph
    yosph
    Community Member
    edited January 2016

    Hi @Rad,

    I see what you mean by not being able to perform Go and Fill. What if the use of SFSafariViewControllers was a toggle option within 1Password settings? Although this would require more code, it could be toggled pretty easily using an if-else statement.

    Thanks!

  • Rad
    Rad
    1Password Alumni

    Thanks for getting back to us, @yosph :+1:

    This is a very nice option indeed: The ability to switch between 1Browser and SFSafariViewControllers.

    I just updated the internal issue (OPI-2626) with your suggestion.

    Thanks so much!

  • yosph
    yosph
    Community Member

    Awesome thanks @Rad

    Have a great day!

  • Rad
    Rad
    1Password Alumni

    Likewise @yosph :blush:

  • A separate but related issue, and one of the primary reasons we'd consider getting rid of 1Browser, is that we currently are required to rate the app 17+ because of 1Browser. If we were to switch to SafariViewController that would no longer be an issue. If we were to have a setting to switch between the two I would imagine the 17+ raiting would have to stay.

    Ben

  • yosph
    yosph
    Community Member

    I saw the recent update! Thanks for pushing this update forward. However, is it possible to allow content blockers to function in 1Password? Perhaps this could be an advanced option.

  • Hi @yosph,

    I believe we would need to switch to SafariViewController in order to do that.

    Thanks!

    Ben

This discussion has been closed.