Autofill not working on GNOME GitLab when saving during account creation

jgoguen

Firefox 61.0.1, Fedora 28, GNOME Shell Xorg, latest 1Password X

On gitlab.gnome.org, if you create a new account and save the login in 1Password, there's two problems:
1. The saved username is the email address, but there's a specific username field.
2. The saved form details are for the registration form and there's no way to edit them.

2 is a problem because GitLab has the login form for all options (in this case LDAP login and standard login) on the same page as the registration form (the forms are just shown based on the selected tab) so 1Password fills the form details for the registration form. Somewhat ironically, if you edit the saved login to set the username to the correct value it fills the registration form incorrectly despite having the saved web form details. When filling credentials, I'm selecting the username field in the form I want filled and choosing the login from the dropdown attached to the field.

Two things that could help:
1. Fill the current form (based on whatever field has focus or has the 1Password dropdown attached to it) as best as possible
2. Allow editing (or even deleting saved web form details.

Granted editing web form details is more of an advanced user thing, but coming from the 1Password desktop app I was expecting to be able to do so and it would have been faster for me to edit the form details than it was to delete and recreate the login.

---

1Password Version: 1Password X
Extension Version: 1Password X Firefox
OS Version: Fedora 28 x64
Sync Type: 1Password X

AGAlumB

@jgoguen: I'm not having any trouble getting 1Password to correctly save the login credentials in the current version, but I'm also seeing the issue with the registration form being filled. We'll see what we can do to improve that. You can also ways save a new login from the login form, and in many cases that will help, but in this case it still fills incorrectly, just in a different way. Thanks for reporting this.

ref: xplatform/filling-issues#245

jgoguen

Right, the problem is filling after saving from the registration form. Which in this case is definitely tricky since all three forms are on the same page and have unique field names. Even removing the web form entries would probably not work. Which is what brought me to the ability to edit the web form fields. That may also help for sites like virginatlantic.com and register4less.com which have a third mandatory field on the login form that doesn't seem to save properly even when saving a brand new login.

AGAlumB

@jgoguen: Editing manually is not a good user experience and not something we can expect most people to do though...and ultimately since 1Password isn't filling correctly anyway that won't help here. We'll have to figure something else out.