1P extension appending hotkey to end of password before submitting

NebbyWan

For the past few days (maybe around the same time the Oct update for Windows came out?) the 1P extension has been failing to log me into sites when utilizing the hotkey (Ctrl-) in the browser. When I watched closely, I could see 1P fill the password field and then it would add an extra character before submitting the form. After seeing this I did a little "inspect element" magic to see what was going on, and it ended up that the extra character was a "\". This doesn't happen when using the Ctrl-Alt-\ sequence and selecting the site or clicking the extension icon and selecting the site. Also, this is happening in both Chrome and Firefox and on two different machines (both running the same version of extension, OS, and 1P). Any suggestions would be helpful.

---

1Password Version: 7.2.581
Extension Version: 4.7.3.90
OS Version: Windows 10 Pro v1809
Sync Type: Not Provided

littlebobbytables

Hi @NebbyWan,

So whatever is happening is new to me. Just as a sanity check, if you change the hotkey to something other than \ does it continue to perform the same odd behaviour but now adding the new character to the end?

I'm also curious, would you say your keyboard style means you're very quick with releasing the keyboard shortcut and do you release the \ key first or at the same time as letting go of the ctrl modifier. The only scenario I can imagine is that with keyboard focus left in the password field that Windows is for unclear reasons interpreting something as typing \. What and why a Windows update would cause any change in behaviour I'm unsure so I'm pretty much guessing at this point.

Something else that would be interesting to learn. If you have a Google or Amazon account, do you see the character appended on the end of the username when filling the first stage?

NebbyWan

Hi @littlebobbytables,

The behavior does not seem affect the email-only fill on sites like Amazon, nor other non-password fields on sites where 1P fills more than just the user/pass (e.g. https://webtma.net). I changed the hotkey to ' and, sure enough, the character that began to be appended changed to '. I played around with how I enter the shortcut and found that the only way to prevent the character from being appended was if I continued to hold ctrl until after 1P finished filling the fields. If there's any other info that I might be able to provide, please let me know.

littlebobbytables

Hello @NebbyWan,

I don't know why but this has to be a Windows bug/quirk of some kind. None of the clients have any code for tacking characters onto the end of a string being used for filling, I can't imagine a scenario where it would actually be useful. It's odd that it isn't consistent over all fields as well. At least you've found a way of reducing the impact and hopefully holding down the ctrl key for a little longer isn't a disruptive change to the workflow even if it may take a little while to adjust. It's a very weird one, it will be interesting to see if we receive any other reports.

NebbyWan

Hey @littlebobbytables

Just following up: apparently the append thing was just another issue w/ that build of Win10 (at least it wasn't the data loss...) since, now that the latest Win10 update has been installed I no longer am seeing the problem on either machine or browser.

Have a good one!

littlebobbytables

Hello @NebbyWan,

After reading about how some people were losing their entire Documents folder I'm guessing having Windows idiotically append a character isn't the worst that could have happened. At least it's behaving more sensibly now and fingers crossed it stays that way. If you experience any other weirdness though please do let us know.