Crash when dragging file onto item list while All Vaults selected

guitarzan

Dragging and dropping a file just about anywhere in the 1Password app seems to have no effect at all, except when dropping the file on the item list when All Vaults is selected.

App crashes with a NullReferenceException:

System.AggregateException: A Task's exception(s) were not observed either by Waiting on the Task or accessing its Exception property. As a result, the unobserved exception was rethrown by the finalizer thread. ---> System.NullReferenceException: Object reference not set to an instance of an object.
   at AgileBits.OnePassword.ItemListView.GetVaultToAddDroppedItems() in C:\code\onepassword-rt\AgileBits.OnePassword.Desktop\UI\Views\ItemListView.xaml.cs:line 521
   at AgileBits.OnePassword.ItemListView.<>c__DisplayClass45_0.<UserControl_Drop>b__0() in C:\code\onepassword-rt\AgileBits.OnePassword.Desktop\UI\Views\ItemListView.xaml.cs:line 557
   at System.Windows.Threading.DispatcherOperation.InvokeDelegateCore()
   at System.Windows.Threading.DispatcherOperation.InvokeImpl()
   --- End of inner exception stack trace ---
   at AgileBits.OnePassword.App.<StartErrorLogging>b__11_1(Object sender, UnobservedTaskExceptionEventArgs e) in C:\code\onepassword-rt\AgileBits.OnePassword.Desktop\App.xaml.cs:line 52
   at System.EventHandler`1.Invoke(Object sender, TEventArgs e)
   at System.Threading.Tasks.TaskScheduler.PublishUnobservedTaskException(Object sender, UnobservedTaskExceptionEventArgs ueea)
   at System.Threading.Tasks.TaskExceptionHolder.Finalize()
---> (Inner Exception #0) System.NullReferenceException: Object reference not set to an instance of an object.
   at AgileBits.OnePassword.ItemListView.GetVaultToAddDroppedItems() in C:\code\onepassword-rt\AgileBits.OnePassword.Desktop\UI\Views\ItemListView.xaml.cs:line 521
   at AgileBits.OnePassword.ItemListView.<>c__DisplayClass45_0.<UserControl_Drop>b__0() in C:\code\onepassword-rt\AgileBits.OnePassword.Desktop\UI\Views\ItemListView.xaml.cs:line 557
   at System.Windows.Threading.DispatcherOperation.InvokeDelegateCore()
   at System.Windows.Threading.DispatcherOperation.InvokeImpl()<---

If a single vault is selected, no crash.

---

1Password Version: 7.0.553
Extension Version: Not Provided
OS Version: Win 7
Sync Type: Dropbox

SergeyTheAgile

@guitarzan that's a good catch, thank you! Fix is coming with next update.