Update Login bugs [confirmed, fixed in 4.1.3]

samangh

There are several bugs in the "Update Login" feature, when using Firefox (with the 1password extension).

Steps to reproduce:

1. Go to Amazon, eBay, AgileBits forums, etc.
2. Change your password
3. Upon pressing "submit' (or similar), a "1 Password Update Login" window appears. Select to "Update an existing Login", and choose the appropriate login from the menu.

Upon pressing Update, 2 things can happen (none of which is what we want!):

1. Either the old Login item is not touched, and a new Password item is created instead; or
2. The correct Login item is edited, but the password is not changed

In both cases, the Login item is also moved from its current folder, and placed in another folder or moved out of all folders completely.

Megan

Hi @samangh,

I would like to apologize for the delay in responding to you here but we have been a bit overwhelmed since the launch of 1Password 4 for Mac. We're all working hard and putting in extra hours to get back to our usual snappy responses and we really appreciate your patience.

Thanks so much for that detailed report. I know that it's been a few days since your original post, so please make sure that you are updated to the most current version (4.1 is the current version for Mac App Store users, and 4.1.1 is the latest version if you purchased from our website.)

Baever

I'm experiencing the same thing with 4.1.1 and Chrome. After updating a password by generating a new password, it prompts me to update the login. I do, but the password associated with the login doesn't update. The password associated with the password does update. I have to manually update the login. If it makes any difference, the login was originally created with 1Password 3.

samangh

I think the problem may be that often thre are 3 password fields when changing a password: one for the old password, and two for the new. While the mini password generator correctly fills the two boxes for the new password, 1Password still the first password field (which is usually the old for the old password) when updating the Login item.

sjk

Hey guys,

I'm sorry you've been having trouble with Login items not being properly updated after making website password changes. The reports here are similar to others about this bug:

We have confirmed that Update existing Login can fail to make changes to the item, while in some cases the item has actually been updated and its details haven't been refreshed.

If you've used Copy or Fill in Password Generator after generating a new password then any of those passwords that didn't properly update password fields of corresponding Login items should still be stored in Password items in the Passwords category.

If you'd like to test a fix for this bug in the current beta build you can join the 1Password Beta Family.

@samangh mentioned:

the Login item is also moved from its current folder, and placed in another folder or moved out of all folders completely.

Are those Login items you've added to folders created with File > New Folder? Do you mean updated items can appear in a different user-created folders than they were originally in?

samangh

Are those Login items you've added to folders created with File > New Folder? Do you mean updated items can appear in a different user-created folders than they were originally in?

Yes. The items move to the folder above the one that is selected. (This looks like a bug related to array[] indexes starting from 0 not 1).

sjk

Hi, @samangh.

I've verified that Update existing Login usage will remove the corresponding Login item from its current folder and sometimes move it to a different one. Bug report filed. Thanks for discovering and reporting this!

samangh

Excellent. "Create new Login" also does the same thing.

sjk

Hi, @samangh.

Do you mean the Save as new Login option in the 1Password Save Login window when a folder is selected? In this example a new Login item was saved in the B folder:

That's when Update existing Login was the default option and the original item remained in the same folder (A) it began in. What steps are you using?

Niklas

Oh darn it, got hit with this bug today. Is there any way to recover the password if the 1P generator wasn't used?

samangh

Do you mean the Save as new Login option in the 1Password Save Login window when a folder is selected?

Yes, thats correct.

That's when Update existing Login was the default option and the original item remained in the same folder (A) it began in. What steps are you using?

This also happens when the Save as New Login is the default option as well. It also happens when you convert a Password item to a Login item.

sjk

Hi, Niklas.

I'm really sorry you've lost a password because of this bug. Unfortunately it can't be recovered from 1Password because there's no record of an unsaved manually entered password. Submitting a "forgot my password" request with the site where this happened is probably your best option.

sjk

Hi, @samangh.

The issues you've reported with items being moved from folders after certain actions should be resolved in the next beta.

sjk

Hi there,

These bugs, reported here, have been fixed in 4.1.3 (current website version) and 4.1.2 (upcoming MAS version, pending Apple's approval) updates.

• Fixed problem when updating a login from a web form with old, new, and confirm password fields (auto-save window).
• Fixed problem when updating a login via the auto-save window. It used to be removed from its original folder.

samangh

This is still happening for both new and updated Login items (when using the auto-save feature). I'm using 4.1.2 (MAS version).

sjk

Hi, @samangh.

I'm really sorry to hear there's still something amiss when you're saving/updating Login items through the auto-save window.

In your original post you mentioned "AgileBits forums" as one of the sites that was troublesome, where I've most recently tested and didn't have any issues with initial Login item creation or subsequent password updates, using 1P 4.1.2/4.1.3 (4.0.1 extension in Safari 7.0.1) on 10.9.1. Is this forum still one of the problematic sites for you?

Can you post a specific example of what isn't working properly now, with site/version details, and we'll try reproducing it here under those conditions? If any lingering bugs are involved we certainly want to squash them. Thanks for your help!

samangh

I think this should be website independent, must be something within the auto-save window/function itself.

Anyway, it happened when I tried to create a new Login item after changing my password on evanscycles.com

sjk

Hi, @samangh.

Let's try to nail down exactly what happened there. :)

When you changed your password on the evanscycles.com site did the 1Password Update Login auto-save window appear normally, with Update existing Login selected to change the existing Login item? Then did you select Save as new Login instead? Similar to this:

Or were there different steps? What was the result and what were you expecting to happen?

Any further information that can help us to understand and reproduce your problem is appreciated. Thanks!