Don't forget to remove debug code

srcoder

Hi guys,

Using the console in the browser a lot and I noticed you're console.log(ing) too.

There is this script content/s.js which creates a uuid and console.log('Content script loaded ${uuid}',window) on every page.
Just a reminder to remove this in the near future.

---

1Password Version: Not Provided
Extension Version: 0.8.4
OS Version: Not Provided
Sync Type: Not Provided

beyer

Hey @srcoder,

Sorry for the slight annoyance, I've gone ahead and removed this for now which you'll see in our next release. There's nothing sensitive in this log entry, but we aren't using it at the moment, so it doesn't need to be there.

Thanks for bringing it up and have a great week. :)

--
Andrew Beyer (Ann Arbor, MI)
Lifeline @ AgileBits

srcoder

You too @beyer!

beyer

Thanks! :) :+1:

pbz

Not sure if that counts as "sensitive information" but there is a local path of the development machine in your bundled background.js file:
/Users/davidteare/.npm-global/lib/node_modules/webpack/node_modules/browserify-sign

Comes from the module elliptic I guess.

beyer

@pbz: Thanks for letting us know. <3

My buddy Mitch has drastically changed our build process this week, and I'm not seeing this anymore. :+1:

I'll double-check in the next release, but we should be good. :)

--
Andrew Beyer (Ann Arbor, MI)
Lifeline @ AgileBits

srcoder

Resolved in 0.8.5 :chuffed:

beyer

Great, thanks for letting us know!

--
Andrew Beyer (Ann Arbor, MI)
Lifeline @ AgileBits