Design language

Ben

The addition of the new "Appearance" preferences definitely helps (Compact/90%) to make it less cartoonish

As someone with old eyes, I'm very glad we decided to offer options here. I've got my zoom set to 125% and density set to comfortable. 👀 To some it may look cartoonish, but I appreciate not having to squint. 😊

Ben

volts

What don't you like about Electron?
  It's basically raccoons in a trenchcoat.
Sure, but what specifically don't you like about it?
  The raccoons doen't look or act like people.
Right, but in what exact ways don't they look or act like people?
  They live in a dumpster and can't talk.
OK, fair enough. But they're cute, right? What words don't they know?
 

---

It's not just context menus. Pull-down menus near the right side of a window always open <-- left because they're scared of the window border.

And in Preferences, menus don't open with the active option selected.

---

 

Zoom weirdness:

Preferences -> Appearance
Increase Interface Zoom from 100% to 200%.

   (The Preferences window explodes to uselessness.)

Close Preferences
Open Preferences again

    (It's back to normal size, ignoring any desired Zoom level.)

Ben

Thanks, @volts! I appreciate you bringing these to our attention.

Zoom weirdness:

Preferences -> Appearance
Increase Interface Zoom from 100% to 200%.

(The Preferences window explodes to uselessness.)

Yep! Sure does. 🤦

I've filed an issue for that.

ref: dev/core/core#14532

Close Preferences
Open Preferences again

(It's back to normal size, ignoring any desired Zoom level.)

I was able to reproduce this one as well, and have filed an issue for it too.

ref: dev/core/core#14533

And in Preferences, menus don't open with the active option selected.

This one I'm not entirely sure I understand. When I open 1Password > Preferences > Appearance > Theme, for example, it does show my current selection ("Match system") as active:

It's not just context menus. Pull-down menus near the right side of a window always open <-- left because they're scared of the window border.

I wasn't able to reproduce this one either. I didn't find any such menu that are near the right border of the window and would be affected. Would you be able to provide an example, please? A screenshot would be very helpful as well.

Thank you.

Ben

volts

On Mac and Windows and Linux, when a pop-up menu item is clicked, the active item should be positioned under the cursor and selected.

1Password menus always pop "down", as in your screenshot. The selected item is indicated with a checkbox, but it's not positioned correctly or selected.

volts

Pop-up menus aren't normally scared of window borders. They should be able to pop up on screen even if they extend past the parent window's edge.

In 1Password 8 they are, which often makes them pop UP and LEFT and requires unnecessary scrolling.

volts

In 1Password 7 - a lovely, well-behaved macOS app - both of those things behave normally.

Pop-ups aren't trapped inside the window border, and the active item is positioned correctly and already activated.

volts

If it's helpful to anybody else, I'm using the built-in Screenshot.app (Command-Shift-5) to record these little clips, and this bit of ffmpeg to make animated GIFs. It's easier than uploading to a 3rd-party site.

ffmpeg -i "Screen Recording.mov" -filter_complex "[0:v] fps=12,scale=iw/2:-1,split [a][b];[a] palettegen [p];[b][p] paletteuse" output.gif

Unknown

This content has been removed.

Unknown

This content has been removed.

Smigit

Just installed 8 and ran it for the first time. Just some quick feedback

However, the change from ⌘0 meaning "all (filtered) vaults" to "reset zoom" is jarring and should have been seen as a problem well before it was implemented. There are two types of apps where I expect to find zoom bindings and will accept ⌘0 as "reset zoom":

Web Browsers (wholeheartedly)
Editors (grudgingly)

I agree with this assessment by @Austin. It's not that returning to a default soon is completely unuseful, but its not something expect to do in apps other than browsers and more to the point the ⌘0 is already accounted for in 1Password 7, as well as ⌘1-9 having a seperate function based on your number of collections within the app. 1-9 does one thing and then one number only carries a different meaning. It's not even a shortcut I use but I can see how it'll stick out to those that do. It's also the sort of thing the Mac user base concerned about Electron might jump on and will just attract the 'its a browser app' criticisms. Someone said one reason they like it is after a long day they may scale their UI, but do people really do that on a single app basis rather than a system level, and to a password manager no less where you probably aren't spending a lot of time? It doesn't seem like a hugely common use case to me, with people likely changing scaling once and then not needing to dynamically tweak it on a per app basis.

The zoom itself also breaks the UI currently too as noted, once it hits around 150%. Preference pane especially however I haven't looked if other areas are impacted.

Looking at some of the notes from @snozdop. The lack of rubber banding really stands out here to me as feeling off. Also the inconsistency with windows. Preferences looks good as someone coming in with what sounds like a recent redesign. It however sticks out that other popups such as collection management and new items are modal. It'd be nice if the preferences behaviour could be made consistent throughout. As an example of where this negatively impacted my flow, when I first accessed the Collections Manager UI it took me a moment on Mac to work out how to cancel out and close the window. Normally I'd expect the three coloured buttons that native MacOS windows have. Failing that my eye was drawn to the disabled 'Cancel' button which felt like a logical thing to click to cancel out of the editor, however that wasn't enabled and is tied to the current collection if modified. The last place I was drawn to was the X in the upper right which isn't where close buttons on Mac windows live.

I'm seeing some poor scrolling performance when scrolling on lists, especially if I scroll slowly. The pane bobs up and down a bit rather than scrolling smoothly. Never noticed this in 7 or other Mac apps (which I've just tested now to be sure). Seeing this when scrolling through my logins, when scrolling through saved info for a single login, etc. Seems to apply when the scrolling starts with the list at the very top. If you start scrolling from a list that's not sitting at the first record performance seems better and I don't get the juddering.

If I have the preference pane open and then select another app. When I next click the 1Password app in the dock I'm finding that the main 1Password window opens however the preference pane is lost behind. By contrast, if in Safari I had the preference pane open, go to another app, then click Safari again on the dock, when Safari s brought to the foreground its done so with the browser being displayed with the preference pane on top, just as the windows were ordered at the time I selected another app. I'll note that the 1Password preference pane does flash for an instance which makes it feel like the OS brought the panes back as expected but something has then triggered the main 1Password window to steal focus away from the preferences pane causing it to be sent to the background.

Not a huge fan of the banner on the "add new" screen with a bunch of options taking up space on a screen that's already quite full. I'd consider making that collapsible or pull that interface element into a new starter wizard. It's not that useful I don't think for longtime users. Part of me would like to see the 'New Item" button incorporate a drop down menu to the right of the button where if clicked would have a vertical list of items that can be added and bypass that initial 'New Item' screen. Might just be me missing the more simple behaviour of the 7 version though when adding something which didn't need a new window.

Overall I think the app looks alright. There's some mannerisms I hope can be improved to make them feel more native (rubber banding and removing modal windows) on Mac, but then other aspects do look and work well such as the main UI. Also reassuring to see that the preference pane has got some attention to make it feel more native, and I hope that attention is given to other windows. Some of these UI quirks stick out when you compare the iOS 8 app using Swift where Apple native things like rubber banding are in effect still which makes this a bit more pronounced.

Unknown

This content has been removed.

Ben

Thanks so much for the additional feedback here. Thanks especially for the animated gifs you provided, @volts. I've added a request that we reconsider how our menus behave in our desktop apps and included those recordings for visual reference.

I appreciate the point about the use of ⌘0 to reset zoom as well. I can see both sides of that.

Ben

ref: IDEA-I-754